Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37695?usp=email )
Change subject: hlr: initial testenv.cfg ...................................................................... Patch Set 3: (1 comment) File hlr/testenv.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37695/comment/212eb6f3_8bb68a48 PS2, Line 6: program=osmo-hlr > would it possibly make sense to use the below patterns as implicit defaults? > So basically just spec […] I have considered doing that, but decided against it for the following reasons: * This may lead to confusing errors down the line, in case the values for `make=`, `package=` and `copy=` inherited from the program name would not be correct. The testenv script would try to e.g. install the wrong package and fail, then users need to spend additional time (way more time than adding these few lines IMHO) to read the docs to understand this implicit behavior, figure out that they need to add a `package=` line and test again. Whereas if we already have a `package=` line it is explicit and self-explaining IMHO. * It could also be that we get config files that look correct, but were only tested with either binary repository or the make target, and the other one could be broken if the implicit value is wrong. By having it explicit, I think it's more likely that people will try to figure out the correct value. * `program=` may be more than just the program name, have environment variables or additional arguments (e.g. `ERL_FLAGS="-config osmo_dia2gsup.config" osmo-dia2gsup`, `osmo-sgsn -c osmo-sgsn.sns.cfg`) or even run a launcher script. But if you feel strongly about this, I could also rework it to separate the commandline from `program=` (adding a new `commandline=` variable), and use defaults for `commandline=`, `make=`, `package=` and `copy=` based on program. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37695?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If937f021a33bf81b4e7296c2efdbd13a73cdaca9 Gerrit-Change-Number: 37695 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Fri, 02 Aug 2024 11:49:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
