fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email )


Change subject: build: do not link against libosmo-abis
......................................................................

build: do not link against libosmo-abis

We use 'struct ipa_client_conn' from libosmo-abis:

  src/sgsn/sgsn_vty.c:56:#include <osmocom/abis/ipa.h>

but do not call any of its API directly, so linking against it
is not necessary.  Remove it from $LDADD, but keep in $CFLAGS.

Change-Id: I11168a7b25942d6c70566441fb0a1d26c3ae5c43
Related: OS#6535
---
M src/sgsn/Makefile.am
M tests/sgsn/Makefile.am
M tests/sndcp_xid/Makefile.am
M tests/xid/Makefile.am
4 files changed, 0 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/93/37793/1

diff --git a/src/sgsn/Makefile.am b/src/sgsn/Makefile.am
index 93b9fa0..487dead 100644
--- a/src/sgsn/Makefile.am
+++ b/src/sgsn/Makefile.am
@@ -79,7 +79,6 @@
        $(top_builddir)/src/gprs/gprs_utils.o \
        $(top_builddir)/src/gprs/sgsn_ares.o \
        $(OSMO_LIBS) \
-       $(LIBOSMOABIS_LIBS) \
        $(LIBOSMOGSUPCLIENT_LIBS) \
        $(LIBCARES_LIBS) \
        $(LIBGTP_LIBS) \
diff --git a/tests/sgsn/Makefile.am b/tests/sgsn/Makefile.am
index c6c1f4a..9cffdfd 100644
--- a/tests/sgsn/Makefile.am
+++ b/tests/sgsn/Makefile.am
@@ -84,7 +84,6 @@
        $(top_builddir)/src/gprs/gprs_llc_parse.o \
        $(top_builddir)/src/gprs/crc24.o \
        $(top_builddir)/src/gprs/sgsn_ares.o \
-       $(LIBOSMOABIS_LIBS) \
        $(LIBOSMOCORE_LIBS) \
        $(LIBOSMOCTRL_LIBS) \
        $(LIBOSMOGSM_LIBS) \
diff --git a/tests/sndcp_xid/Makefile.am b/tests/sndcp_xid/Makefile.am
index c4702b8..08bd27f 100644
--- a/tests/sndcp_xid/Makefile.am
+++ b/tests/sndcp_xid/Makefile.am
@@ -10,7 +10,6 @@

 sndcp_xid_test_LDADD = \
        $(top_builddir)/src/sgsn/gprs_sndcp_xid.o \
-       $(LIBOSMOABIS_LIBS) \
        $(LIBOSMOCORE_LIBS) \
        $(LIBOSMOGSM_LIBS) \
        $(LIBOSMOGB_LIBS) \
diff --git a/tests/xid/Makefile.am b/tests/xid/Makefile.am
index d3a260b..284e392 100644
--- a/tests/xid/Makefile.am
+++ b/tests/xid/Makefile.am
@@ -27,7 +27,6 @@

 xid_test_LDADD = \
        $(top_builddir)/src/sgsn/gprs_llc_xid.o \
-       $(LIBOSMOABIS_LIBS) \
        $(LIBOSMOCORE_LIBS) \
        $(LIBOSMOGSM_LIBS) \
        $(LIBOSMOGB_LIBS) \

--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I11168a7b25942d6c70566441fb0a1d26c3ae5c43
Gerrit-Change-Number: 37793
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>

Reply via email to