Attention is currently required from: neels.

Jenkins Builder has posted comments on this change by neels. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/37760?usp=email )

Change subject: n-sessions [4/4]: implement 'n <0-2147483647> session create'
......................................................................


Patch Set 2:

(2 comments)

File src/osmo-pfcp-tool/pfcp_tool_vty.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17588):
https://gerrit.osmocom.org/c/osmo-upf/+/37760/comment/0c89ec7c_4115261d?usp=email
 :
PS2, Line 830:  "Let some time pass until events have occured\n"
'occured' may be misspelled - perhaps 'occurred'?


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17588):
https://gerrit.osmocom.org/c/osmo-upf/+/37760/comment/6201b129_b5185463?usp=email
 :
PS2, Line 1096:         int n = (strcmp("all", argv[0]) == 0? -1 : 
atoi(argv[0]));
spaces required around that '?' (ctx:VxW)



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37760?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I74a21cc31296ab89a2acda1da8ae9693c1992e66
Gerrit-Change-Number: 37760
Gerrit-PatchSet: 2
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Mon, 05 Aug 2024 06:23:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to