Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37642?usp=email )
Change subject: filesystem: add export method for ADF files ...................................................................... Patch Set 2: (1 comment) File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/37642/comment/2590ecb7_7b50d3f2?usp=email : PS2, Line 538: this assumes that every application will have an 'export' method. I believe this is not the case (particularly not with this patch alone)? There's two ways I can see: * have an Application base class export method that does nothing, and then override that method in the ARA-M application to acutally do something, selectively * do a hasattr() here to check if the application has an export method, and only call it in that case. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8129656096ecaf41b36e5f2afbbfbebcd0587886 Gerrit-Change-Number: 37642 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 14:36:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
