Attention is currently required from: fixeria. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37741?usp=email )
Change subject: pySim.esim.saip.templates: Add expand_default_value() method ...................................................................... Patch Set 2: (1 comment) File pySim/esim/saip/templates.py: https://gerrit.osmocom.org/c/pysim/+/37741/comment/339c816c_6ee68ec5?usp=email : PS2, Line 55: or 100 > just too be sure: is this intentional and coming from some spec. […] no, it is just a random value. The return value of the below call is not actually used anywhere. All we want to do here is to verify that *if* we later need to actually compute the default value, it will work. So we're just verifying that the pattern from the template can be processed as the comment states below. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id3eb16910c0bdfa572294e14ca1cd44ca95ca69f Gerrit-Change-Number: 37741 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 15:55:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
