Attention is currently required from: fixeria, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email )
Change subject: After writing VTY config, run sync() in a different thread ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Not saying there can't be a better way, though ;) […] I am quite sure the reason is "because it was easy to do". We don't care about whatever operations happen on the old file. We really only care that the newly written file has been written. So IMHO what is needed is fsync() on the [new] file itself, as well as fsync to the directory cotnaining the file. The "link" call (working with path names) might need to change to "linkat" (work with directory file descriptors)? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 12 Aug 2024 19:04:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
