Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37824?usp=email )
Change subject: fix msgb memleak on GTP echo response ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-upf/upf_gtpu_echo.c: https://gerrit.osmocom.org/c/osmo-upf/+/37824/comment/81f63d2f_8da0a9c0?usp=email : PS1, Line 91: sendto this is of course a valid fix. Seeing all those hand-rolled socket operations, I'm wondering if it wouldn't make sense to migrate this over to osmo_io. For sure it's not a performance critical code path - but it would avoid having to manually have a read_cb, reading from the socket, etc. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I2bd2e9c57bf392074eed9628a69eb710d4e459a6 Gerrit-Change-Number: 37824 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Sat, 17 Aug 2024 05:08:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
