Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37760?usp=email )
Change subject: pfcp-tool: n-sessions [4/4]: implement 'n <0-2147483647> session create' ...................................................................... Patch Set 4: (1 comment) File src/osmo-pfcp-tool/pfcp_tool_vty.c: https://gerrit.osmocom.org/c/osmo-upf/+/37760/comment/eb2346b1_05794817?usp=email : PS4, Line 1069: if (!(i & 0x3f) && responses_pending) { > N is 0x3f then? sounds a bit cryptic tbh. Maybe it'd be better to parametrize how many maximum pending requests in flight should be possible instead. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I74a21cc31296ab89a2acda1da8ae9693c1992e66 Gerrit-Change-Number: 37760 Gerrit-PatchSet: 4 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2024 09:12:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
