Attention is currently required from: pespin.

Jenkins Builder has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email )

Change subject: Replace gprs_ra_id with modern osmo_routing_area_id
......................................................................


Patch Set 1:

(3 comments)

File src/sgsn/gprs_gmm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17837):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/c34bc857_aa9ec34a?usp=email
 :
PS1, Line 1216:                 gprs_rai_to_osmo(&ra_id 
,&MSG_IU_UE_CTX(msg)->ra_id);
space prohibited before that ',' (ctx:WxO)


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17837):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/3c123e63_90683234?usp=email
 :
PS1, Line 1216:                 gprs_rai_to_osmo(&ra_id 
,&MSG_IU_UE_CTX(msg)->ra_id);
space required after that ',' (ctx:WxO)


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17837):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/eebc7aaf_8230af20?usp=email
 :
PS1, Line 1216:                 gprs_rai_to_osmo(&ra_id 
,&MSG_IU_UE_CTX(msg)->ra_id);
space required before that '&' (ctx:OxV)



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia41eb8f51d3836b1bc65325ff1ec6bdb16e20c7e
Gerrit-Change-Number: 37860
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 19 Aug 2024 09:13:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to