Attention is currently required from: fixeria, lynxis lazus, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/37724?usp=email )
Change subject: gmm: Introduce interface GMMBSSGP ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gprs/gmm/gmm_prim.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/37724/comment/feb7b728_6102c0e0?usp=email : PS1, Line 369: /* Alloc primitive for GMMBSSGP SAP: */ > objectively, the names are unusually long indeed. […] The idea at some point (when we stabilize the API) is to have a single alloc API for the entire set of primitives sharing a parent struct. But as mentioned, this can be done at a later point and then be done for all APIs at once, which will be easier, so I really plan to merge this as is for now. Having the way it is now it makes it easier to initial integration since users of the library can easily see which primitives are expected to be pushed to the library and which ones received from it. Having implemented most of the upper layers GPRS stack in the MS side, I found this useful since it's not always clear when/how to use/expect the primitives, and the SGSN code is already too mangled so having it like for now is useful while we develop support for libosmo-gprs on a branch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/37724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I39045833fd43cfe98cb1a3812fbce3fdcaae6dc6 Gerrit-Change-Number: 37724 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2024 10:23:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
