Attention is currently required from: laforge, neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email )
Change subject: on RUA Connect failure, respond with RUA Disconnect ...................................................................... Patch Set 2: (1 comment) File src/osmo-hnbgw/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807/comment/3a994d91_d9f55bc3?usp=email : PS2, Line 313: tx_disconnect: I find this goto here not really useful and adding complexity to the code, since it's only used in one code path and the function above has no general "return" statement just above. I'd say either move this entire code block directly where it belongs, or put it in a static helper function and call it in the code path where it belongs. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iafb30c31a4c5db53ecdda99a0e0b5937b71e362c Gerrit-Change-Number: 37807 Gerrit-PatchSet: 2 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2024 10:33:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
