Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email )
Change subject: After writing VTY config, run sync() in a different thread ...................................................................... Patch Set 5: Code-Review-1 (1 comment) Patchset: PS5: what's the outcome of the discussion in here? IMHO moving all this to a thread is overkill. If at all, I'd improve the situation making the several steps delayed through several main loop calls (FSM?) to avoid longer lockings. In any case, any time critical operations should be processed in a separate thread with appropiate priority, so I don't think this is a reason to backup the complexity in here just for seldom writes to config files imho. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: Hoernchen <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2024 10:45:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
