Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email )
Change subject: Reject M3UA with "M3UA Network Appearance" ...................................................................... Patch Set 7: (1 comment) File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/6e77a1ff_02fa0488?usp=email : PS7, Line 386: if (asp) { tbh, seeing it this way now, imho this logging message most probably belongs to whatever parent is calling this function, not here. The log should be done at the code path where it is detected (hence providing meaningful file+line) instead of here when generating the error message. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f Gerrit-Change-Number: 37817 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2024 13:09:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
