Attention is currently required from: daniel, lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37872?usp=email )
Change subject: sgsn: Introduce test TC_attach_rau_a_b_wrong_old_ra ...................................................................... Patch Set 1: Code-Review+1 Copied votes on follow-up patch sets have been updated: * Code-Review+1 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN"). (1 comment) Patchset: PS1: > Ah I didn't see/remember it because afaict it was not listed in > https://projects.osmocom. […] It was mentioned in the ticket description: """ I have fixed the regression in SGSN_Tests.TC_attach_rau_a_b and created a separate testcase reproducing the crash: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625 sgsn: add TC_attach_rau_invalid_old_rai [NEW] """ and you even did code review 😄 I am fine merging your patch and abandoning mine, just wanted to clarify. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ce02f30a1e5becb80ab2a29f6bf5d08dd45b79c Gerrit-Change-Number: 37872 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2024 09:19:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
