Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmocore/+/37881?usp=email )
Change subject: CTRL: get rate_ctr_group by the id from rate_ctr_group_set_name() ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Patchset: PS2: A name of a rate_ctr could be a a string of digits. I think we should instead have a new "rate_ctr_name" CTRL procedure which allows fetching rate_ctr by name, since those are clearly 2 different operations. File src/core/rate_ctr.c: https://gerrit.osmocom.org/c/libosmocore/+/37881/comment/4b402f78_071df36d?usp=email : PS2, Line 282: if (name && !osmo_identifier_valid(name)) looks like a different patch? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I841a12f76e6fcb2bd7aecb5f4b1707d9ec927137 Gerrit-Change-Number: 37881 Gerrit-PatchSet: 2 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Wed, 21 Aug 2024 09:30:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
