Attention is currently required from: neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmocore/+/37981?usp=email )
Change subject: coverity CID#272974 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/37981/comment/b78a5528_aef86129?usp=email : PS1, Line 7: coverity CID#272974 Would be nice to have a brief problem description in the commit message, at least for reviewers to understand what kind of issue a given patch is fixing without having to open slow-as-hell Coverity web UI and look-up themselves. Can be copy-pasted from Coverity, e.g. ``` >>> CID 273001: Insecure data handling (TAINTED_SCALAR) >>> Passing tainted expression "needed" to "recv", which uses it as an offset. 1444 rc = recv(fd, msg->tail, needed, 0); ``` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5633c3218067685036b79fd8d827031eede1eaa0 Gerrit-Change-Number: 37981 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Tue, 03 Sep 2024 05:11:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
