Attention is currently required from: fixeria.

dexter has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/37947?usp=email )

Change subject: suci-tutorial: add section about SUCI calculation by the USIM
......................................................................


Patch Set 2:

(5 comments)

Commit Message:

https://gerrit.osmocom.org/c/pysim/+/37947/comment/36eeba27_d2c2fb07?usp=email :
PS1, Line 9: The tutorial describes how SUCI calculation in the UE is configure,
> +d
Done


https://gerrit.osmocom.org/c/pysim/+/37947/comment/677bba6c_b7d0fae5?usp=email :
PS1, Line 10: ad
> +d
Done


File docs/suci-tutorial.rst:

https://gerrit.osmocom.org/c/pysim/+/37947/comment/70d64187_521e22de?usp=email :
PS1, Line 204: The sysmoISIM-SJA5-S17 *SUCI
> Looks like something is missing here, like "The sysmoISIM-SJA5-S17 supports 
> ...".
Done


https://gerrit.osmocom.org/c/pysim/+/37947/comment/1d02c88f_8ab0bfc2?usp=email :
PS1, Line 227: changed
> s/changed/changes/
Done


https://gerrit.osmocom.org/c/pysim/+/37947/comment/c08b3a96_2d44e424?usp=email :
PS1, Line 230: as well
> maybe say "in addition to service 124" to make it cleaner?
Done



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37947?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I45d47f9278b30d99ebde6891de0ba8cc74b1a0a0
Gerrit-Change-Number: 37947
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Tue, 03 Sep 2024 07:36:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to