Attention is currently required from: fixeria.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958?usp=email )

Change subject: s1gw: Initial StatsD support
......................................................................


Patch Set 2:

(2 comments)

File s1gw/S1GW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958/comment/6c19e244_e1b8fd4c?usp=email
 :
PS2, Line 79: VirtHNBGW
> copy-paste
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958/comment/f64bab9e_75e4d692?usp=email
 :
PS2, Line 112: f_new_ConnHdlrPars
> [At least now] I don't really see the need for this function. […]
Because one needs to pass mp_statsd_prefix everytime, and beter doing it once 
here than in every test.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib98c2fe68006a8d0f45de6966927b349a3b933ca
Gerrit-Change-Number: 37958
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Tue, 03 Sep 2024 08:31:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to