Attention is currently required from: fixeria, laforge.

dexter has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/37819?usp=email )

Change subject: Add testsuite for pySim-shell with real cards
......................................................................


Patch Set 16:

(2 comments)

File tests/pySim-shell_test/ara_m/test.py:

https://gerrit.osmocom.org/c/pysim/+/37819/comment/ee8e6d4a_ad5d6d31?usp=email :
PS15, Line 27: self.setup(__file__)
> Either what @[email protected] suggested, or adding a class variable should 
> work. […]
Thanks for your hints. Now it works!


https://gerrit.osmocom.org/c/pysim/+/37819/comment/11e90de4_e5f687d8?usp=email :
PS15, Line 35: self.cleanup()
> I would prefer a solution that does not have to define a class variable in 
> every derived class (test […]
Done



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de
Gerrit-Change-Number: 37819
Gerrit-PatchSet: 16
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Tue, 03 Sep 2024 15:13:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>

Reply via email to