Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040?usp=email )
Change subject: s1gw: send the actual Recovery Time Stamp ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040/comment/b472a354_7d854161?usp=email : PS1, Line 242: f_pfcp_get_recovery_timestamp())); It probably makes more sense to pass this value as a param of f_pfcp_handle_assoc_setup_req(), so that it only needs to be fetched once at the start of the test, avoiding unnecessary extra ping pong messages? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I350d28289526d8264ef9b70e796ef76ee7fcbb4b Gerrit-Change-Number: 38040 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 05 Sep 2024 12:18:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
