Attention is currently required from: laforge, lynxis lazus, neels. jolly has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email )
Change subject: sip.c: permit early media with both 183 and 180 ...................................................................... Patch Set 1: (1 comment) File src/sip.c: https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039/comment/8edd3127_d3140feb?usp=email : PS1, Line 85: if (status == 183 || status == 180) What if "180 Ringing" result does not contain SDP? sdp_extract_sdp() would print error log message, but this is not an error. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79 Gerrit-Change-Number: 38039 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: jolly <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Thu, 05 Sep 2024 13:11:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
