Attention is currently required from: fixeria, pespin. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37992?usp=email )
Change subject: coverity CID#216829 ...................................................................... Patch Set 5: Code-Review-1 (1 comment) File src/rtp.c: https://gerrit.osmocom.org/c/libosmo-netif/+/37992/comment/2d98c5be_1a9a347f?usp=email : PS4, Line 151: if (payload_len < 0) { > This is no longer possible according to checks above. […] ah no, we cannot drop this, but also there is a mistake in patch set 1, because: payload_len can still be zero. If we want to read a padding length octet from the end, payload_len must be >= 1. So we need a check here, but it should be if (payload_len < 1) instead of 0. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37992?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I30beeac45ff2d8c08905986af9fabfda071ddc5b Gerrit-Change-Number: 37992 Gerrit-PatchSet: 5 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2024 00:32:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]>
