Attention is currently required from: pespin. dexter has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38052?usp=email )
Change subject: Initial support for >256 BTS ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Patchset: PS4: To me this patch looks reasonable. Did you test it? Maybe it makes sense to create a config with 256 (+ a few more) fake BTSs and then add one real BTS on top to see if actually works? File src/osmo-bsc/bts_ericsson_rbs2000.c: https://gerrit.osmocom.org/c/osmo-bsc/+/38052/comment/3887f9e8_b89d404a?usp=email : PS4, Line 200: } This looks fine to me. I also think that it is ok not to fix this right now. Maybe you should also mention that there is a limitation with the PCUIF interface as well? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I607a68efeb5f4a50cce107d11d3c5126b7d8f81a Gerrit-Change-Number: 38052 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2024 11:27:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
