pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/38078?usp=email )
Change subject: Log unsupported PCUIF for bts > 255
......................................................................
Log unsupported PCUIF for bts > 255
Change-Id: If5a8cd94195422989de3daa04be7ffc858c0a8eb
---
M src/osmo-bsc/pcu_sock.c
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/38078/1
diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c
index 83513f6..02a3d84 100644
--- a/src/osmo-bsc/pcu_sock.c
+++ b/src/osmo-bsc/pcu_sock.c
@@ -367,6 +367,10 @@
return;
if (!bsc_co_located_pcu(bts))
return;
+ if (bts->nr > 0xff) { /* OS#6565 */
+ LOG_BTS(bts, DPCU, LOGL_ERROR, "bts id > 255 cannot be
configured over PCUIF! GPRS won't work for this BTS!");
+ return;
+ }
/* In cases where the CCU is connected via an E1 line, we transmit the
connection parameters for the
* PDCH before we announce the other BTS related parameters. */
@@ -429,6 +433,11 @@
return -EINVAL;
}
+ if (bts->nr > 0xff) { /* OS#6565 */
+ LOG_BTS(bts, DPCU, LOGL_ERROR, "CHAN RQD(GPRS) on bts id > 255
cannot be sent over PCUIF! GPRS won't work for this BTS!");
+ return -EINVAL;
+ }
+
LOG_BTS(bts, DPCU, LOGL_INFO, "Sending RACH indication: qta=%d, ra=%d, "
"fn=%d\n", qta, ra, fn);
@@ -887,6 +896,11 @@
struct gsm_bts_trx *trx;
int j;
+ if (bts->nr > 0xff) { /* OS#6565 */
+ LOG_BTS(bts, DPCU, LOGL_ERROR, "bts id > 255 cannot be
configured over PCUIF! GPRS won't work for this BTS!");
+ return;
+ }
+
/* activate PDCH */
llist_for_each_entry(trx, &bts->trx_list, list) {
for (j = 0; j < ARRAY_SIZE(trx->ts); j++) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38078?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If5a8cd94195422989de3daa04be7ffc858c0a8eb
Gerrit-Change-Number: 38078
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
