Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38166?usp=email )
Change subject: pySim-prog: rework documentation ...................................................................... Patch Set 2: (3 comments) File docs/legacy.rst: https://gerrit.osmocom.org/c/pysim/+/38166/comment/690b09de_c821043e?usp=email : PS1, Line 46: KI, OPc > depends on whether we merge the patch you just added to derive those from the > 'secret'... Let's keep this one open until we made a decision. https://gerrit.osmocom.org/c/pysim/+/38166/comment/2c40e4be_2e7f0c14?usp=email : PS1, Line 62: * supersim : * magicsim : * fakemagicsim : * grcardsim : * sysmosim-gr1 : * sysmoSIM-GR2 : * sysmoUSIM-SJS1 : * Fairwaves-SIM : * OpenCells-SIM : * Wavemobile-SIM : * sysmoISIM-SJA2 : * sysmoISIM-SJA5 : * gialersim > I guess those should be alphabetically sorted? Done https://gerrit.osmocom.org/c/pysim/+/38166/comment/f4682013_0dc218cf?usp=email : PS1, Line 110: , > extra comma should probably be removed Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1d1a65154cea7fa77428b412fcf8c7b4cba629b1 Gerrit-Change-Number: 38166 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Mon, 16 Sep 2024 11:55:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
