Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/pysim/+/38164?usp=email )
Change subject: pySim-prog: generate Ki and OPc value using _digits() function
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> When we use the the _digits function, then we have the advantage that we can
> identify the entire dat […]
If we wanted to *properly* solve the problem, we should use an established and
well-cryptanalyzed KDF (key derivation function) for deriving keys from a
master key/seed. However, given that pySim-prog is legacy I really don't want
us to spend more time on it. We should rather be working on a replacement for
batch-programming based on pySim-shell and get rid of pySim-{read,prog}.
Since nobody has reported a problem with how the K/OPc are generated so far, I
would just keep it as-is (without your patch). If anyone feels different, let
us know here.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/38164?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib53d9d04a2073dafcca7cd21b0324bee5a23c540
Gerrit-Change-Number: 38164
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Mon, 16 Sep 2024 16:39:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>
