laforge has submitted this change. (
https://gerrit.osmocom.org/c/pysim/+/38162?usp=email )
Change subject: pySim-prog: add FIXME note to tell that writing hlr.db files is
broken
......................................................................
pySim-prog: add FIXME note to tell that writing hlr.db files is broken
The writing to osmo-hlr SQLITE files is broken since the SQLITE format
has evolved over time. Let's add a FIXME note to tell that this needs
fixing.
Related: SYS#4120
Change-Id: I2b23f8bb9f3c2adeb48b010834057f5b4fb1e626
---
M pySim-prog.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/pySim-prog.py b/pySim-prog.py
index 8d330cb..e238b66 100755
--- a/pySim-prog.py
+++ b/pySim-prog.py
@@ -623,6 +623,9 @@
def write_params_hlr(opts, params):
# SQLite3 OpenBSC HLR
+ # FIXME: The format of the osmo-hlr database has evolved, so that the code
below will no longer work.
+ print("Warning: the database format of recent OsmoHLR versions is not
compatible with pySim-prog!")
+
if opts.write_hlr:
import sqlite3
conn = sqlite3.connect(opts.write_hlr)
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/38162?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2b23f8bb9f3c2adeb48b010834057f5b4fb1e626
Gerrit-Change-Number: 38162
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
