Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email )

Change subject: library/s1ap: comment out optional IE in 
tr_S1AP_InitialCtxSetupResp
......................................................................


Patch Set 1:

(2 comments)

File library/s1ap/S1AP_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277/comment/e37e3bc6_b6a5cbc5?usp=email
 :
PS1, Line 734:                                  /*, {
what's wrong with sending this? You are not explaining why. Furthermore, I'd 
expect we want to test this case in ttcn3.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277/comment/3c23788a_9b047b0e?usp=email
 :
PS1, Line 755:                          protocolIEs := {
then please use superset() here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4765036be69ff10adb8c510d4092834c4e923229
Gerrit-Change-Number: 38277
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 25 Sep 2024 11:17:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to