Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38117?usp=email )
Change subject: ts_51_011: replace encoding of EF.MSISDN with construct model ...................................................................... Patch Set 10: (1 comment) File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/38117/comment/10dc5393_c09c3c99?usp=email : PS10, Line 191: _test_de_encode = [ plese also add some test vectors for the letacy case with `{'msisdn'...` so we know that doesn't break. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38117?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I647f5c63f7f87902a86c0c5d8e92fdc7f4350a5a Gerrit-Change-Number: 38117 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 21:35:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
