Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email )
Change subject: tests/vty: Add vty-transcript-test for osmo-stp ...................................................................... Patch Set 3: (1 comment) File tests/vty/osmo_stp_test.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347/comment/d92e4a3f_0edaa202?usp=email : PS3, Line 104: description .TEXT > This is a generic command from libosmovty (`cfg_description_cmd`), are you > sure it should be tested […] I just copied the file from ss7_asp_test.vty to have similar testing for both asp and sg. So I think this is really orthogonal to the patch at hand. I can submit an extra commit removing it from both files. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If2f069b9d724038c326f5c35848faa1e9c216fd5 Gerrit-Change-Number: 38347 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 07 Oct 2024 15:49:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
