Attention is currently required from: pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350?usp=email )

Change subject: src/osmo_ss7_vty.c: Improve error formatting in 'update route' 
cmd
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File src/osmo_ss7_vty.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350/comment/ba3d6b00_a34d6f49?usp=email
 :
PS1, Line 399: Invalid arg count %d
I find this message over-complicated a bit, maybe say `Incomplete command 
(missing an argument?)`? Not critical, feel free to merge as-is.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38350?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I4fd5b30093425f1831348282d3563467c889e27f
Gerrit-Change-Number: 38350
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 07 Oct 2024 16:53:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to