Attention is currently required from: daniel, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email )
Change subject: GMM: split parsing of a RA Update Request in a separate file ...................................................................... Patch Set 14: (5 comments) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/f1d2e37d_b88af41b?usp=email : PS5, Line 1624: LOGMMCTXP(LOGL_NOTICE, mmctx, "Update type %i unsupported in Mode III, is your SI13 corrupt?\n", req.update_type); > > Use %d instead of %i […] Done File src/sgsn/gprs_gmm_util.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/8f549f47_0ebfdf30?usp=email : PS5, Line 98: if (msgb_l3len(msg) < (len + (cur - msgb_gmmh(msg)))) > > that open brace { should be on the previous line […] Done https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/6058083d_eeb9e0dc?usp=email : PS5, Line 108: if (msgb_l3len(msg) == mandatory_fields_len) { > > braces {} are not necessary for single statement blocks […] Done https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/534fce5d_a6eb4867?usp=email : PS5, Line 115: if (ret < 0) { > > braces {} are not necessary for single statement blocks […] Done File src/sgsn/gprs_gmm_util.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/6067b7e3_bf612e8a?usp=email : PS8, Line 31: /* 9.4.14 RAU Request */ > This is already present in gprs_gmm_util. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d Gerrit-Change-Number: 37869 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Tue, 08 Oct 2024 18:45:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: daniel <[email protected]>
