Attention is currently required from: laforge, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/38107?usp=email )

Change subject: libvlr: replace direct call of paging_expired() into a callback
......................................................................


Patch Set 3:

(2 comments)

Patchset:

PS3:
The build should succeed as soon the libosmocore commit hits the docker images.


File src/libmsc/sgs_iface.c:

https://gerrit.osmocom.org/c/osmo-msc/+/38107/comment/be689812_45e34c52?usp=email
 :
PS2, Line 473: int sgs_iface_tx_paging(struct vlr_subscr *vsub, enum 
sgsap_service_ind serv_ind)
> yeah, it's mostly the name which is misleading, if it's doing more than 
> transmit.
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38107?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7a3d15e8f0fb51c6b32add2de5024fc4d599ecf0
Gerrit-Change-Number: 38107
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 08 Oct 2024 22:54:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: lynxis lazus <[email protected]>

Reply via email to