Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38374?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: tests/vty: Show bug inserting routes with different priority
......................................................................
tests/vty: Show bug inserting routes with different priority
route lookup ((hmrt_message_for_routing() => osmo_ss7_route_lookup() =>
osmo_ss7_route_find_dpc_mask())) iterates the list of routes assuming they are
ordered by mask length (so it doesn't need to iterate the full list every
time). Similary, it implicitly seems to assume that the entries are also
sorted by priority.
However, priority is not currently taken into account when being
inserted in the routing table, so the route ends up in the incorrect
place.
This commit adds a VTY test showing the wrong insert.
Related: SYS#7112
Change-Id: I125046fcbc7563c3275f42ff9de2aa351ae616c1
---
M tests/vty/Makefile.am
A tests/vty/osmo_stp_route_prio.vty
2 files changed, 90 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran
refs/changes/74/38374/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38374?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I125046fcbc7563c3275f42ff9de2aa351ae616c1
Gerrit-Change-Number: 38374
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
