Attention is currently required from: daniel, fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email )
Change subject: Add Routing Areas ...................................................................... Patch Set 17: (2 comments) File tests/gprs_routing_area/gprs_routing_area_test.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/aee395b9_8091b327?usp=email : PS15, Line 329: static struct log_info_cat gprs_categories[] = { > Yet you're missing to add `DRA` here... Thank you, I overlooked it (again). Will add it. File tests/testsuite.at: https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/3b05c5b6_2467a78e?usp=email : PS15, Line 21: ignore > Done, but no changes from previous revision? No, there aren't any changes. I still think it is fine, not checking the stderr. This unit test don't depend on log line matching. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa Gerrit-Change-Number: 37864 Gerrit-PatchSet: 17 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Fri, 11 Oct 2024 17:06:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]>
