Attention is currently required from: lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email )

Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE 
correct
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File sgsn/BSSGP_ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397/comment/5a007fa3_d4cf9cfe?usp=email
 :
PS1, Line 680: altstep as_service_request(boolean ue_in_pmm_idle := true, 
integer ran_index := 0) runs on BSSGP_ConnHdlr {
I'd leave this as "boolean exp_service_acc". Leave the "state" information to 
the caller wishing to call this.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I29237997e414aea80f254247da54f909410a4b36
Gerrit-Change-Number: 38397
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Fri, 11 Oct 2024 22:07:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to