Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38405?usp=email )
Change subject: vlr: add defines for vlr_is_cs() vlr_is_ps() ...................................................................... Patch Set 2: (1 comment) File include/osmocom/vlr/vlr.h: https://gerrit.osmocom.org/c/osmo-msc/+/38405/comment/d3953fa7_b75d3295?usp=email : PS2, Line 121: #define vlr_is_cs(vlr) (!vlr->cfg.is_ps) > missing () around "vlr" And btw, it probably makes sense to have this as a static inline to check for types. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I88810f3703813e98be8a37d0445ad641b0cac11d Gerrit-Change-Number: 38405 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Fri, 11 Oct 2024 22:25:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
