Attention is currently required from: lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email )

Change subject: SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request 
the IMEI
......................................................................


Patch Set 2:

(1 comment)

File sgsn/BSSGP_ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/131d4bce_bdb229ef?usp=email
 :
PS2, Line 561:  f_process_attach_accept(l3_mt.msgs.gprs_mm.attachAccept, 
ran_index);
Now it becomes clearer.
This should imho be refactored to an alt {
[] as_mm_identity(ran_index) { repeat; }
[] as_attach_accept() { f_process_attach_accept()}
}



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id49c9e6ef7517a6a831315ac1f9915c50b88beb6
Gerrit-Change-Number: 38398
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Fri, 11 Oct 2024 22:46:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to