Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email )
Change subject: SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Like in the other patch, I'm not a fan of widening the expectations of our test cases. IMHO, if we know that the current VLR doesn't and the new one does, then we should introduce some kind of variable/module_parm and change that once we merge the VLR code to osmo-sgsn. A test should always be as narrow as possible. Otherwise we risk a future behavioural change of the implementation (potential regression) passing unnoticed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11c628ecebbe7c4c1b2c28e63133a33cfc171e12 Gerrit-Change-Number: 38399 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Sat, 12 Oct 2024 16:55:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
