Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email )
Change subject: ss7 vty: Fix insert order of routes with higher priority ...................................................................... Patch Set 5: (1 comment) File tests/vty/osmo_stp_route_prio.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/4ae0ddab_5f17d8e6?usp=email : PS2, Line 87: 3.2.1/14 0 as3 ? ? ? > @[email protected] I'm fine with that, I can do that in a follow-up patch. > Something related to discuss though: We are currently storing the value in > uint32_t value in strcut osmo_ss7_route cfg. > We could make that one a uint8_t, but that may break ABI compatibility.I'll > check because anyway since we added secondary_pc we are already breaking ABI > since last version. I wouldn't bother. It doesn't hurt to store that value as uint32_t at all. > TBH I think we should break ABI once and move as many as possible of those > structs into private headers. Same goes for most of the APIs too. > This would make it far easier improving the library, since anyway when adding > features will keep otherwise breaking ABI again and again. That's a separate discussion, unrelated. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6e7b5e3f06ae2c9468da58c55d2f42cbcd777218 Gerrit-Change-Number: 38375 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Sat, 12 Oct 2024 19:48:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
