Attention is currently required from: laforge, pespin.

osmith has posted comments on this change by osmith. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38382?usp=email )

Change subject: ggsn: add test TC_pdp4_clients_interact_with_ext_hdr
......................................................................


Patch Set 3:

(1 comment)

File ggsn_tests/GGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38382/comment/2ad70060_1c58ad98?usp=email
 :
PS2, Line 1434:                 g_gtpu_hdr_opt_part := {
> looks like we want to add a template for this...
does this make sense? depending on how many extension headers you add, it would 
look quite differently so I'm not sure if abstracting it further here would be 
useful



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38382?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic767f8b50f034171d71cae16512d1d26a07b24bf
Gerrit-Change-Number: 38382
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 14 Oct 2024 13:56:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to