Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38356?usp=email )
Change subject: vlr: use correct types for vlr_timer ...................................................................... Patch Set 1: (1 comment) File include/osmocom/vlr/vlr.h: https://gerrit.osmocom.org/c/osmo-msc/+/38356/comment/5e2ae4db_100f31d4?usp=email : PS1, Line 427: unsigned long vlr_timer(struct vlr_instance *vlr, int timer); > Sometime I find it hard fixing one thing and getting such review of, please > fix also this thing, whi […] Well you got my +1 anyway, I'm just mentioning in case you want to and it's a quick thing, for the benefit of everybody looking at the code later on. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38356?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic46ddb578962619fc08bd63645c76852e676fcc9 Gerrit-Change-Number: 38356 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Mon, 14 Oct 2024 14:21:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]>
