Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38406?usp=email )
Change subject: vlr: set the correct CN domain on GSUP messages ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: IMHO it makes more sense to have some kind of a wrapper function, like vlr_gsup_client_mux_tx() which then can set something like this at one single locatin in the code. That way it is not copy+pasted all over the place, and no single caller (also in the future) can forget to set this field correctly. if it's a static function inside the vlr.c file the compiler will inline it and there's not even any function call overhead at runtime. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I045f29647b0f122a653881030d09de35b64f4dd1 Gerrit-Change-Number: 38406 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 15:45:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
