Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38433?usp=email )
Change subject: sgsn: Validate TLI received in RAB Ass Req ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > at a high level it looks a bit like this could/should be possible ot handle > with @decmatch and a lot […] while I agree decmatch is useful in several places, I believe in this specific case it is fine leaving as is. why? Because the TLA octet decoding actually needs some heuristic logic to try to figure out whether it's using a raw IP address or an X.213 formatted IP address. One needs to check the size of the octet buffer in order to figure out which type of address it is, and then validate it checking values in the octet string, etc. So ideally in there we'd have a function checking that kind of heuristics, like ranap_transp_layer_addr_decode2() does. But since here I know osmo-sgsn is apparently always sending an X.213 address I didn't care implementing the function for now. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38433?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a3699cea981caa89b30742c031d5f232418b0ee Gerrit-Change-Number: 38433 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Wed, 16 Oct 2024 10:13:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
