pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38467?usp=email )

Change subject: library/PCO_Types: Drop unused nonsense enum
......................................................................

library/PCO_Types: Drop unused nonsense enum

That enum is PAP related, plus it doesn't really match the section
describing, plus it's not used anywhere.
Looks like a development artifact which was not dropped during submit.

Change-Id: Ic791d20dd600b039daa2abef7fa25aaa6780a448
---
M library/PCO_Types.ttcn
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve




diff --git a/library/PCO_Types.ttcn b/library/PCO_Types.ttcn
index 0eaa45e..a308c08 100644
--- a/library/PCO_Types.ttcn
+++ b/library/PCO_Types.ttcn
@@ -59,13 +59,6 @@
        IPCP_OPT_SECONDARY_DNS  (131) /* RFC 1877 1.2 */
 } with { variant "FIELDLENGTH(8)" };

-/* RFC 1334, section 3.2. Packet Format */
-type enumerated PAP_CODE_ {
-       PAP_CODE__IPADDR        (1),
-       PAP_CODE__PRIMARY_DNS   (2),
-       PAP_CODE__SECONDARY_DNS (3)
-} with { variant "FIELDLENGTH(8)" };
-
 type set of ProtocolElement ProtocolIDList;

 type record ProtocolElement {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38467?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic791d20dd600b039daa2abef7fa25aaa6780a448
Gerrit-Change-Number: 38467
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>

Reply via email to