pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38549?usp=email )


Change subject: cosmetic: Add some comments with spec references
......................................................................

cosmetic: Add some comments with spec references

Change-Id: I131dca5be9313d3beb51ec9d5f507552ae6c9d84
---
M include/osmocom/sccp/sccp_types.h
M include/osmocom/sigtran/protocol/sua.h
2 files changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran 
refs/changes/49/38549/1

diff --git a/include/osmocom/sccp/sccp_types.h 
b/include/osmocom/sccp/sccp_types.h
index 17018d2..bc11258 100644
--- a/include/osmocom/sccp/sccp_types.h
+++ b/include/osmocom/sccp/sccp_types.h
@@ -189,6 +189,7 @@
        SCCP_PROTOCOL_RETURN_MESSAGE        = 8,
 };

+/* ITU-T Q.713, Section 3.11 Release cause */
 enum sccp_release_cause {
        SCCP_RELEASE_CAUSE_END_USER_ORIGINATED      = 0,
        SCCP_RELEASE_CAUSE_END_USER_CONGESTION      = 1,
@@ -209,6 +210,7 @@
        SCCP_RELEASE_CAUSE_SCCP_FAILURE             = 16,
 };

+/* ITU-T Q.713, Section 3.12 Return cause */
 enum sccp_return_cause {
        SCCP_RETURN_CAUSE_NO_TRANSLATION_NATURE     = 0,
        SCCP_RETURN_CAUSE_NO_TRANSLATION            = 1,
@@ -227,6 +229,7 @@
        SCCP_RETURN_CAUSE_SEGMENTATION_FAILURE      = 14
 };

+/* ITU-T Q.713, Section 3.13 Reset cause */
 enum sccp_reset_cause {
        SCCP_RESET_CAUSE_END_USER_ORIGINATED        = 0,
        SCCP_RESET_CAUSE_SCCP_USER_ORIGINATED       = 1,
@@ -242,6 +245,7 @@
        SCCP_RESET_CAUSE_RESERVED                   = 11,
 };

+/* ITU-T Q.713, Section 3.14 Error cause */
 enum sccp_error_cause {
        SCCP_ERROR_LRN_MISMATCH_UNASSIGNED          = 0, /* local reference 
number */
        SCCP_ERROR_LRN_MISMATCH_INCONSISTENT        = 1,
@@ -250,7 +254,7 @@
        SCCP_ERROR_UNQUALIFIED                      = 4,
 };

-/* ITU=T Q.713 Section 3.15 */
+/* ITU-T Q.713 Section 3.15 Refusal cause */
 enum sccp_refusal_cause {
        SCCP_REFUSAL_END_USER_ORIGINATED            = 0,
        SCCP_REFUSAL_END_USER_CONGESTION            = 1,
diff --git a/include/osmocom/sigtran/protocol/sua.h 
b/include/osmocom/sigtran/protocol/sua.h
index 70c16ba..4ce88f9 100644
--- a/include/osmocom/sigtran/protocol/sua.h
+++ b/include/osmocom/sigtran/protocol/sua.h
@@ -130,6 +130,7 @@
 #define SUA_RI_HOST    3
 #define SUA_RI_SSN_IP  4

+/* 3.10.6. SCCP Cause: Cause Type */
 #define SUA_CAUSE_T_MASK       0xff00
 #define SUA_CAUSE_T_RETURN     0x0100
 #define SUA_CAUSE_T_REFUSAL    0x0200

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38549?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I131dca5be9313d3beb51ec9d5f507552ae6c9d84
Gerrit-Change-Number: 38549
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>

Reply via email to