Patch Set 1: Code-Review-1 (2 comments)
https://gerrit.osmocom.org/#/c/6098/1/ggsn/ggsn.c File ggsn/ggsn.c: Line 710: * \param[in] v4v6 IP version to select. Valid values are 4 and 6. Why not use smth like "bool is_ipv6"? Line 725: OSMO_ASSERT(v46==4 || v46==6); This would eliminate the need for this check for example. -- To view, visit https://gerrit.osmocom.org/6098 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6d18a64c2b71f3bcf6cb7e3a978d2d3f9c7a79b Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
