Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/38557?usp=email )
Change subject: CSD NT modes: transmit properly aligned RLP frames on DL ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: You could perhaps split this commint into 2: First one moving stuff to new file, second one doing the changes. File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/38557/comment/87c258d8_89a4c876?usp=email : PS2, Line 1520: bool good_rlp; you can probably move this to a more specific scope below, since this function is quite large and then it's difficult to figure out where is this used. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idaebfce6da13b23ba265a197502712d83991873e Gerrit-Change-Number: 38557 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: falconia <[email protected]> Gerrit-Comment-Date: Sun, 27 Oct 2024 19:50:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
