Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/38556?usp=email )
Change subject: csd_v110_rtp_decode: preserve E2 & E3 bits for RLP alignment ...................................................................... Patch Set 2: (1 comment) File src/common/csd_v110.c: https://gerrit.osmocom.org/c/osmo-bts/+/38556/comment/e8674549_fbb46b1a?usp=email : PS2, Line 213: align_accum <<= 2; > IIUC desc->num_blocks can never be >4 then right? Correct. 4 is the greatest possible number of V.110 frames per 20 ms clearmode packet of TS 48.103 section 5.6, occurring only in TCH/F9.6 mode. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I43b97caa6030b9401779998ca5dddc4cfe636e2f Gerrit-Change-Number: 38556 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Sun, 27 Oct 2024 20:43:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
