Attention is currently required from: fixeria.

fixeria has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38578?usp=email )

Change subject: library/s1ap: rework {ts,tr}_S1AP_RABSetupRsp templates
......................................................................


Patch Set 1:

(2 comments)

File library/s1ap/S1AP_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38578/comment/def5edd7_7e908340?usp=email
 :
PS1, Line 1287: template E_RABSetupResponse
I am not adding `(present)` restriction here because I need to do 
`rsp.protocolIEs[idx] := *` below. If I add it, the code does not compile 
(TITAN complains about violating template restrictions).


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38578/comment/4cd623a2_57ca2353?usp=email
 :
PS1, Line 1321: rsp.protocolIEs[idx] := *;
Sadly, we cannot use `superset` here because the `protocolIEs[]` is a `record 
of`, while `superset` wants a `set of`. Adding `*` at the end results in a 
template that matches at most those IEs that are preceding it (in fixed order) 
and ignores the remaining IEs (if any).



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38578?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic369ae720179483a19383af2bddf56186965eae3
Gerrit-Change-Number: 38578
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Tue, 29 Oct 2024 21:27:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to